- bulk update of repository options #939
Conversation
|
any updates on getting this merged? |
|
bueller? as someone who has contributed to this project before, it's super frustrating to do this work and then see the PR languish and other things merged ahead of it. |
|
@bitwiseman hi! what needs to be done on my end to get some traction on this? |
|
@jgangemi This is a solid, high-quality change. Thanks for including tests and javadoc. Great work! I've invited you to the Also, as long as you're going to do this level of work, I'd be grateful if you would try implementing this using |
| private GHCreateRepositoryBuilder getCreateBuilder(String name, boolean useOrg) throws IOException { | ||
| GitHub github = getGitHubBeforeAfter(); | ||
|
|
||
| if (useOrg) { |
There was a problem hiding this comment.
Instead of having this be a parameter that gets passed down through the call stack, this should be a setting like mockGitHub.isUseProxy() but on AbstractGitHubWireMockTest, something like isTestWithUserAccount(). This will let users create, debug, and record tests using their account, but also easily turn it off and re-record from the test account later.
There was a problem hiding this comment.
i feel like i followed this from some other example but i can see about addressing this.
|
@bitwiseman no worries. i'll take a look at what you suggested and get going on these changes. |
|
@bitwiseman sorry for the delay on my end, changes made. let me know your feedback. i set the default behavior to use the "org" to run tests and to set a property for a user account. i updated the |
It appears that the correct way to pass these booleans is as booleans not as strings. Fixes #765
Description
allows bulk updating of repository settings instead of making individual calls for each.
Before submitting a PR:
We love getting PRs, but we hate asking people for the same basic changes every time.
master. Create your PR from that branch.mvn clean compilelocally. This may reformat your code, commit those changes.mvn -D enable-ci clean install sitelocally. If this command doesn't succeed, your change will not pass CI.When creating a PR: